This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Simpler C++ API #25
Open
Simpler C++ API #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… helpful. next to simplify the GET requests so there isn't so much repeated curl calls everywhere.
…SON parsing easier.
| const std::string devURL = "http://rsense-dev.cs.uml.edu/api/v1"; | ||
| const std::string local_baseURL = "http://localhost:3000"; | ||
| const std::string localURL = "http://localhost:3000/api/v1"; | ||
| const std::string live_baseURL = "http://isenseproject.org"; |
|
I fixed the live URL (added https) and made the email / password blank, so they won't be on GitHub. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the C++ API by removing redundant code, and moving copied code into functions, like get_data_funct, post_data_function, empty_project_check and check_http_code. These functions were previously copied all over the place and it made the code longer and harder to read then it needed to be.
In the future I'll probably look into using a different JSON library to simplify a few other places (all the looping in get_dataset is due to restrictions with the current libary, PicoJSON).