Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary mutex, add ecc_fe::is_infty, add ecc_num::set_rnd #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codedust
Copy link

@codedust codedust commented Jan 9, 2020

No description provided.

@MartKro
Copy link

MartKro commented Jan 14, 2020

Just removing is dangerous. This is because the specifiers used in the relic library are implementation dependent and therefore the behavior is now undefined (OPENMP also explicitly states that using the directive outside of an #pragma omp is undefined behavior)
#27 goes in a similar direction but also
(1) introduces the PTHREAD MULTI definition such that the __thread specifier is used
(2) the relic mutex now also uses the __thread specifier if the MULTI directive is PTHREAD.
I've researched that __thread is also an specifier for C++0X for certain comilers and commented that the variable should be changed if the code doesn't compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants