Accept integers as min/max values of DecimalField #9515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good call, yep. |
browniebroke
changed the title
browniebroke
force-pushed
the
decimal-field-min-max-values-types
branch
from
d2ab1ef to
9fef0f6
Compare
auvipy
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type of min/max values for
DecimalFieldshould beDecimalobjects since #8972 and we turn this into a Python warning in #9367. However, @terencehonles pointed out that integers should be accepted.Update the warning to ignore integers and clarify in the docs what types are accepted.