Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate packaging to pyproject.toml #9056
base: master
Are you sure you want to change the base?
migrate packaging to pyproject.toml #9056
Changes from 22 commits
3136996
401de87
6019f1d
121caba
c2062da
a71ed6a
0bcd152
34840fd
9b6e714
cf25dcd
040ded0
9ce6b62
c4bcfc4
2770f5e
6f8da97
2ef6126
c8030fc
0101d89
c1c39d4
561bd4c
29205f0
1278968
06bebc2
ea10c54
5729b02
7770fe4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're disabling namespaces? I believe you can also just specify the packages directly since there is only one:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disabled them because they were disabled originally, using
find_packages
in the setup.py instead offind_namespace_packages
. I tried your suggestion but it broke the CI, so I reverted it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for trying. It appears I misunderstood the default behavior for nested packages.
You'd need to try the following:
I used the
build
module to build a wheel and with my original suggestion it was warning that the sub-packages were not being included, but with theinclude
statement it worked as intended and bundled the sub-packages.Do you mind running that by the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. But as it is changing the behavior, even if it works, I would like it in a separate PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well what you used doesn't match the original either, since you're missing the exclude so I'd just switch to the new style using include and you can leave off the namespace disabling or turn it off if you really prefer it to be off. I just don't think it needs to be off.