support django 2.1+ test client json data automatically serialized

[terencehonles]

Description

• Support Django 2.1+ test client auto serializing data if the content type is a json type
• Ensure the result of _encode_data is always Tuple[bytes, str] rather than Tuple[Union[bytes,str], str]

[auvipy]

to have a better review need to add a test for the proposed change.

[rpkilby]

I'm definitely going to agree with @auvipy here. A test case demonstrating the behavior change would be required for this to be accepted.

My immediate reaction is "why aren't our tests failing under Django 2.1+?"

[terencehonles]

@rpkilby updated with a test

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[terencehonles]

Updated to master

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[terencehonles]

bumped, I think the failed test was unrelated but this re-run the test suite

[auvipy]

also, please rebase, and I think we might get rid of some checks to eleminate older version check

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[terencehonles]

The failing test should be fixed by #9129

[auvipy]

can you rebase? and check if any document or test update is needed to get this merged? also a reference to django docs related to this would be really helpful

[terencehonles]

can you rebase? and check if any document or test update is needed to get this merged? also a reference to django docs related to this would be really helpful

It's mentioned here https://docs.djangoproject.com/en/4.2/topics/testing/tools/#django.test.Client.post (specifically), and it's mentioned in the 2.1 release notes https://docs.djangoproject.com/en/4.2/releases/2.1/#tests (point 2)

I'm not sure if you're asking for this to be included in the source, since there's not specifically a good place to put it (maybe the tests?), or if you're just asking for the release notes.

[terencehonles]

@auvipy friendly ping, I can rebase, but wondering about ^^^

[auvipy]

looks good to me. should we also mention this in DRF docs?

[terencehonles]

Sure, I'll rebase and mention it.

One thing that I realized with this request factory, when testing something yesterday, is that it returns a Django not a DRF request. This means that trying to access the request.data doesn't work. I had to wrap it in a DRF request manually so I switched back to the native factory to get the encoding and not to confuse my peers since this PR still hasn't landed.

I will look at the code, but would it be acceptable to return a DRF request instead? It proxies the native request so it's not a breaking change. I will look at the code, but from memory I think I can actually initialize it in way that would make sense. I will also look at the test client to make sure it does not rely on the factory or that if it does it works correctly.

[terencehonles]

I've left out changing the return type to Response, so I've just rebased and updated the docs.

[auvipy]

Thanks, will review it again soon

review comment addressed