Skip to content

Commit

Permalink
Fix overriding retry settings in PatchPipelineRun
Browse files Browse the repository at this point in the history
We never doubled of the retry when Patching the Pipelinerun as committed
here:

16cbdcc

Do actually use this.

Signed-off-by: Chmouel Boudjnah <[email protected]>
  • Loading branch information
chmouel authored and savitaashture committed Oct 28, 2024
1 parent 78e6c84 commit b6a60aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/action/patch.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func PatchPipelineRun(ctx context.Context, logger *zap.SugaredLogger, whatPatchi
doubleRetry.Duration *= 2
doubleRetry.Factor *= 2
doubleRetry.Jitter *= 2
err := retry.RetryOnConflict(retry.DefaultRetry, func() error {
err := retry.RetryOnConflict(doubleRetry, func() error {
patch, err := json.Marshal(mergePatch)
if err != nil {
return err
Expand Down

0 comments on commit b6a60aa

Please sign in to comment.