-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro-optimize randomFill. NFC #23309
Conversation
47cfa63
to
8c31063
Compare
e441d89
to
7e556bf
Compare
7e556bf
to
91223c1
Compare
Interrestingly enough it seems that the builtin
|
91223c1
to
bddfb23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see there is automerge, so removing lgtm. but lgtm with the unneeded files removed
bddfb23
to
61bcbd4
Compare
Only use the node fallback code when its actually needed, otherwise assume that `crypto.getRandomValues` is available out-of-the-box (which it is on node v19 and above.
61bcbd4
to
763f700
Compare
Only use the node fallback code when its actually needed, otherwise assume that
crypto.getRandomValues
is available out-of-the-box (which it is on node v19 and above.