Remove POLYFILL_OLD_MATH_FUNCTIONS setting
#23262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Dec 30, 2024
There was a problem hiding this comment.
I'm confused, where is this documented?
Our minimum supported browser versions are currently chrome 45, firefox 40, safari 10.1 and node 10.19.
I searched for some of those version numbers under src/ and site/ and can't find them. The docs for MIN_CHROME say something else, 33 instead of 45:
Line 1922 in 5a8d9e5
33 would be too old for this change IIANM, I think we need 38 according to MDN. But I think it should be fine to bump to that, separately?
sbc100
force-pushed
the
POLYFILL_OLD_MATH_FUNCTIONS
branch
from
e382b21 to
25b9ac1
Compare
Oops, I was looking at feature_matrix.py which was out of sync for some reason: #23264. |
kripken
approved these changes
Dec 30, 2024
sbc100
force-pushed
the
POLYFILL_OLD_MATH_FUNCTIONS
branch
3 times, most recently
from
f9f0fc4 to
3ab7eaf
Compare
These polyfills are only needed on ancient browser versions that there should be no need to support. This change bumps out minimum required chrome version from 33 to 38.
sbc100
force-pushed
the
POLYFILL_OLD_MATH_FUNCTIONS
branch
from
3ab7eaf to
6fdd8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These polyfills are only needed on ancient browser versions that there
should be no need to support.