Cleanup randomFill. NFC #23260
Merged
Cleanup randomFill. NFC #23260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
cleanup_randomFill
branch
from
86cf5c7 to
36eae7f
Compare
sbc100
force-pushed
the
cleanup_randomFill
branch
2 times, most recently
from
f5b5499 to
366fd05
Compare
kripken
approved these changes
Dec 30, 2024
Under node we can rely on randomFillSync always being available since its been around since v9: https://nodejs.org/api/crypto.html#cryptorandomfillsyncbuffer-offset-size Also, remove the return value from this function since it always fills the entire buffer. https://caniuse.com/getrandomvalues
sbc100
force-pushed
the
cleanup_randomFill
branch
from
366fd05 to
541213e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under node we can rely on
randomFillSyncalways being available sinceits been around since v9.0.0:
https://nodejs.org/api/crypto.html#cryptorandomfillsyncbuffer-offset-size
Also, remove the return value from this function since it always fills
the entire buffer.
https://caniuse.com/getrandomvalues