Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib.glfw3] added support for pthread #23245

Merged

Conversation

ypujante
Copy link
Contributor

Following some user request, I made the necessary changes to the code as well as the port file to add pthread support. I followed the pattern in other ports (like sdl2) for adding the -pthread option when settings.PTHREAD is defined and used the same extension for the library name (-mt).

@ypujante
Copy link
Contributor Author

The failing test is the following:

======================================================================
ERROR [0.003s]: test_memorygrowth_linear_step (test_core.wasm64)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.10.7/lib/python3.10/unittest/case.py", lin

@hoodmane
Copy link
Collaborator

That seems to be a common flake, I reran the CI for you. Hopefully it won't flake again...

@ypujante
Copy link
Contributor Author

Thank you. All tests are passing now.

@sbc100 sbc100 merged commit b94d6e6 into emscripten-core:main Dec 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants