Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_fs_mkdir_dotdot on windows. NFC #23223

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Disable test_fs_mkdir_dotdot on windows. NFC #23223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5859,6 +5859,8 @@ def test_fs_rename_on_existing(self):
self.do_runf('fs/test_fs_rename_on_existing.c', 'success')

@also_with_nodefs_both
@crossplatform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does @crossplatform do? I had assumed that it wouldn't run on windows if we didn't include @crossplatform. Does it add crossplatform tests to the PR CI? And they are always run on the main branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly subtle. the actual @crossplatform decorator just marks the test as being a test that might have different behavior across platforms, and we run those tests on Mac and Windows on the CI that runs on Github (we run only those test to keep CI times costs down). But the builders we use to build the EMSDK releases (which run on chromium's CI infrastructure) do run all of the 'other' and some of the core test suites on Mac and Windows. So that's why we've been catching these failures after they've already landed in the emscripten repo. Usually it works fine, but you've hit basically the one area of work where it's an annoyance. :) Probably for these kinds of tests you should either mark them @crossplatform or explicitly disable them on Windows. As for how much effort you should put in, noderawfs has always sort of been "best-effort" on Windows. Maybe we should try to come up with a better-defined policy, but maybe for now a decent tradeoff would be to start by trying out your tests as crossplatform and if it's not too much effort to make them work, do that, and otherwise just disable on Windows?

@no_windows('https://github.com/emscripten-core/emscripten/issues/8882')
def test_fs_mkdir_dotdot(self):
self.do_runf('fs/test_fs_mkdir_dotdot.c', 'success')

Expand Down
Loading