Remove unnecessary await in MODULARIZE=instance mode. NFC
#23219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the init function is already marks as async it fine/better to simply return the promise here rather than awaiting on it.
sbc100
changed the title
await in MODULARIZE=instance mode. NFCawait in MODULARIZE=instance mode. NFC
|
I might land this TBR since @brendandahl is already out for the holidays and the seem fairly self-evidently fine. |
kripken
approved these changes
Dec 18, 2024
Yes, either way the caller will receive a promise in return, since that is what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the init function is already marks as async it fine/better to simply return the promise here rather than awaiting on it.