Ensure the ino we give to readdir matches the ino we give to stat #23139
Conversation
Fix problem with directory permissions
|
Okay I updated this again, but now it conflicts with #23058, like several other changes I want to make. So ideally we should merge that one first and then I can update this PR to reflect those changes. |
This rule was lost in the recent switch from flake8. This change brings back that rule which is currently in preview in ruff. See #23139 (comment)
|
Maybe |
|
|
Yes we should fix that. Perhaps add a comment to this new test that it should be merges one day if possible. |
|
Okay I think I addressed all the comments here. |
This rule was lost in the recent switch from flake8. This change brings back that rule which is currently in preview in ruff. See emscripten-core#23139 (comment)
|
It seems that if the node working directory does not have execute permissions, this makes |
IIRC that is exactly what the execute bit on a directory means: "can this directory be listed" |
| void setup() { | ||
| // If the node working directory does not have execute permissions, then | ||
| // `fs.readdir` will fail. For that reason we have to work in a subdirectory | ||
| // and remove execute permissions from that. |
There was a problem hiding this comment.
I don't understand.. fs.readdir should fail on any directory that doesn't have the execute bit set, regardless of weather that is CWD or a sub directory, right?
There was a problem hiding this comment.
I suppose I can drop the chmod, but cding into a subdirectory does fix the test, at least when I run it locally. I don't really have a clear theory as to why since it seems a bit illogical.
There was a problem hiding this comment.
Ah, yes, I misremembered. The x bit is about traversing the heirachy, not list-ability. You can list directory than don't have the x bit set. That is what the r bit is for.
If we stat a file in the nodefs it gives a different value for the inode than if we use readdir. Readdir gives the inode in the host file system, stat gives the inode in the native file system. Ideally they should agree about what the inode is.