Update compiler-rt to LLVM 19.1.4 #22937
Merged
+1,190
−986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
changed the title
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (9) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 128974 => 128954 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_ctors2.size: 128423 => 128403 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_except.size: 171008 => 170988 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_except_wasm.size: 142223 => 142203 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_except_wasm_exnref.size: 144810 => 144790 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_lto.size: 121924 => 121904 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_mangle.size: 232517 => 232497 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_noexcept.size: 131781 => 131761 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_wasmfs.size: 168928 => 168908 [-20 bytes / -0.01%] Average change: -0.01% (-0.02% - -0.01%) ```
sbc100
approved these changes
Dec 19, 2024
| @@ -20,4 +20,4 @@ Modifications | |||
|
|
|||
| For a list of changes from upstream see the compiler-rt files that are part of: | |||
|
|
|||
| https://github.com/llvm/llvm-project/compare/llvmorg-17.0.4...emscripten-core:emscripten-libs-17 | |||
| https://github.com/llvm/llvm-project/compare/llvmorg-19.1.4...emscripten-core:emscripten-libs-19 | |||
There was a problem hiding this comment.
It looks like this is currently and empty diff. Is that because emscripten-libs-19 is currently empty?
There was a problem hiding this comment.
Yeah I forgot to upload that branch... Will do that.
| @@ -1 +1 @@ | |||
| 168928 | |||
There was a problem hiding this comment.
Nice to see code sizes going down!
|
I think this can be merged now. When I first uploaded this PR |
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (9) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 128914 => 128894 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_ctors2.size: 128363 => 128343 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_except.size: 170948 => 170928 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_except_wasm.size: 142163 => 142143 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_except_wasm_exnref.size: 144750 => 144730 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_lto.size: 121864 => 121844 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_mangle.size: 232457 => 232437 [-20 bytes / -0.01%] other/codesize/test_codesize_cxx_noexcept.size: 131721 => 131701 [-20 bytes / -0.02%] other/codesize/test_codesize_cxx_wasmfs.size: 168868 => 168848 [-20 bytes / -0.01%] Average change: -0.01% (-0.02% - -0.01%) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes are upstream changes except for a few unused variable warning fixes and code size rebaselines.
This PR was created by running https://github.com/emscripten-core/emscripten/blob/main/system/lib/update_compiler_rt.py script.