Move main loop handling code to library_eventloop.js. NFC #22615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
kripken
approved these changes
Sep 24, 2024
sbc100
force-pushed
the
eventloop
branch
4 times, most recently
from
5b521e6 to
d073cec
Compare
This means that programs that use the main event loops don't need to depend on the `Browser` object. We already supported and test the main loops handling code on node, but programs that only use the event loop without any other `Browser` functions no longer need to pull in the whole `Browser` object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that programs that use the main event loops don't need to depend on the
Browserobject.We already supported and test the main loops handling code on node, but programs that only use the event loop without any other
Browserfunctions no longer need to pull in the wholeBrowserobject.