Skip to content

Commit

Permalink
[test] Remove also_with_wasmfs_js. NFC (#23185)
Browse files Browse the repository at this point in the history
The only different here with `also_with_wasmfs` was that this decorator
adds `FORCE_FILESYSTEM`, but the only test to use this decorator was
already adding this flag.
  • Loading branch information
sbc100 authored Dec 16, 2024
1 parent df004b2 commit f53a7ac
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions test/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,23 +157,6 @@ def decorated(f):
return decorated


# Similar to also_with_wasmfs, but also enables the full JS API
def also_with_wasmfs_js(func):
assert callable(func)

@wraps(func)
def decorated(self):
func(self)
print('wasmfs')
if self.get_setting('STANDALONE_WASM'):
self.skipTest("test currently cannot run both with WASMFS and STANDALONE_WASM")
self.set_setting('WASMFS')
self.set_setting('FORCE_FILESYSTEM')
self.emcc_args = self.emcc_args.copy() + ['-DWASMFS']
func(self)
return decorated


def with_asyncify_and_jspi(f):
assert callable(f)

Expand Down Expand Up @@ -5757,7 +5740,7 @@ def test_fs_trackingdelegate(self):
self.do_run_in_out_file_test('fs/test_trackingdelegate.c')

@also_with_noderawfs
@also_with_wasmfs_js
@also_with_wasmfs
def test_fs_writeFile(self):
if self.get_setting('WASMFS'):
self.set_setting("FORCE_FILESYSTEM")
Expand Down

0 comments on commit f53a7ac

Please sign in to comment.