Skip to content

Commit

Permalink
[ci] Fix "Check test expectations" step so it checks out the target b…
Browse files Browse the repository at this point in the history
…ranch
  • Loading branch information
sbc100 committed Dec 18, 2024
1 parent 91f9825 commit ec8ff7f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,15 @@ jobs:
echo "JS_ENGINES = [NODE_JS]" >> $EM_CONFIG
echo "final config:"
cat $EM_CONFIG
- name: Check test expectations on main
- name: Check test expectations on target branch
if: github.event_name == 'pull_request'
run: |
git checkout origin/main
git checkout ${{ github.base_ref }}
# Hack to honor changes to rebaseline_tests.py in the current PR
git checkout - ./tools/maint/rebaseline_tests.py
./bootstrap
if ! ./tools/maint/rebaseline_tests.py --check-only; then
echo "Test expectations are out-of-date on the main branch."
echo "Test expectations are out-of-date on the target branch."
echo "You can run `./tools/maint/rebaseline_tests.py --new-branch`"
echo "and use it to create a seperate PR."
exit 1
Expand Down

0 comments on commit ec8ff7f

Please sign in to comment.