Skip to content

Commit

Permalink
Switch to Chrome Unstable with new Headless mode (#20069)
Browse files Browse the repository at this point in the history
After Chrome updated, we can now use unstable/dev with new headless mode and all
tests pass once more.

Previously a Chrome update caused beta to fail with either old or new headless.
  • Loading branch information
kripken authored Sep 14, 2023
1 parent c65a321 commit a5e0710
Showing 1 changed file with 13 additions and 8 deletions.
21 changes: 13 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@ commands:
command: |
# TODO: Make these part of the base image
apt-get install libu2f-udev libvulkan1
#wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-beta_current_amd64.deb
# wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-beta_current_amd64.deb
# If that download link breaks, temporarily use this URL instead:
# TODO(sbc): Disable this once we figure out whats up with the
# current beta.
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
# wget -O ~/chrome.deb https://storage.googleapis.com/webassembly/chrome/google-chrome-stable_current_amd64.deb
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-unstable_current_amd64.deb
dpkg -i ~/chrome.deb
emsdk-env:
description: "emsdk_env.sh"
Expand Down Expand Up @@ -350,7 +349,7 @@ commands:
# --no-sandbox because we are running as root and chrome requires
# this flag for now: https://crbug.com/638180
CHROME_FLAGS_BASE: "--no-first-run -start-maximized --no-sandbox --use-gl=swiftshader --user-data-dir=/tmp/chrome-emscripten-profile --enable-experimental-web-platform-features"
CHROME_FLAGS_HEADLESS: "--headless --remote-debugging-port=1234"
CHROME_FLAGS_HEADLESS: "--headless=new --remote-debugging-port=1234"
CHROME_FLAGS_WASM: "--enable-experimental-webassembly-features --js-flags=\"--experimental-wasm-memory64 --experimental-wasm-stack-switching --experimental-wasm-type-reflection\""
CHROME_FLAGS_NOCACHE: "--disk-cache-dir=/dev/null --disk-cache-size=1 --media-cache-size=1 --disable-application-cache --incognito"
command: |
Expand All @@ -359,11 +358,17 @@ commands:
# that are not included by "./embuilder build ALL". For example the
# PIC version of libSDL which is used by test_sdl2_misc_main_module
export EM_FROZEN_CACHE=""
echo
echo "browser"
echo
# skip test_zzz_zzz_4gb_fail as it OOMs on the current bot
test/runner browser skip:browser.test_zzz_zzz_4gb_fail skip:browser.test_zzz_zzz_4gb_fail_wasm64
echo
echo "emrun"
echo
# TODO(sbc): Re-enable once we figure out why the emrun tests are
# locking up.
# test/runner emrun
# skip test_zzz_zzz_4gb_fail as it OOMs on the current bot
test/runner posixtest_browser.test_pthread_create_1_1 browser skip:browser.test_zzz_zzz_4gb_fail skip:browser.test_zzz_zzz_4gb_fail_wasm64
- upload-test-results
test-sockets-chrome:
description: "Runs emscripten sockets tests under chrome"
Expand All @@ -378,7 +383,7 @@ commands:
# --no-sandbox becasue we are running as root and chrome requires
# this flag for now: https://crbug.com/638180
CHROME_FLAGS_BASE: "--no-first-run -start-maximized --no-sandbox --use-gl=swiftshader --user-data-dir=/tmp/chrome-emscripten-profile"
CHROME_FLAGS_HEADLESS: "--headless --remote-debugging-port=1234"
CHROME_FLAGS_HEADLESS: "--headless=new --remote-debugging-port=1234"
CHROME_FLAGS_WASM: "--enable-experimental-webassembly-features --js-flags=\"--experimental-wasm-memory64\""
CHROME_FLAGS_NOCACHE: "--disk-cache-dir=/dev/null --disk-cache-size=1 --media-cache-size=1 --disable-application-cache --incognito"
command: |
Expand Down

0 comments on commit a5e0710

Please sign in to comment.