Make CI param for extra cflags, so node version can be injected only …

…for one step
emscripten-core · Dec 20, 2024 · 7bbbb67 · 7bbbb67
1 parent 3caad8d
commit 7bbbb67
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -240,6 +240,10 @@ commands:
         description: "Name of given test suite"
         type: string
         default: ""
+      extra-cflags:
+        description: "Extra EMCC_CFLAGS"
+        type: string
+        default: ""
     steps:
       - when:
           # We only set EMTEST_RETRY_FLAKY on pull requests.  When we run
@@ -250,6 +254,8 @@ commands:
             set-retry-flaky-tests
       - run:
           name: run tests (<< parameters.title >>)
+          environment:
+            EMCC_CFLAGS: << parameters.extra-cflags >>
           command: |
             env
             ./test/runner << parameters.test_targets >>
@@ -739,7 +745,6 @@ jobs:
     environment:
       LANG: "C.UTF-8"
       EMTEST_SKIP_V8: "1"
-      EMCC_CFLAGS: "-sMIN_NODE_VERSION=101900"
     steps:
       - checkout
       - run:
@@ -750,8 +755,7 @@ jobs:
       - install-node-canary
       - run-tests:
           title: "node (canary)"
-          environment:
-            EMCC_CFLAGS: "-sMIN_NODE_VERSION=101900"
+          extra-cflags: "-sMIN_NODE_VERSION=101900"
           test_targets: "
             other.test_deterministic
             other.test_gen_struct_info