library_pthread.js: Ensure transferredCanvasNames is iterable

This was first broken back in #17577 and then fixed in #17752. I then broke it again in #22545 (yay!) (see #22620). This time I will include a test to ensure this doesn't happen again.
emscripten-core · Sep 25, 2024 · 77435b0 · 77435b0
1 parent 77e24ae
commit 77435b0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/library_pthread.js b/src/library_pthread.js
@@ -716,8 +716,8 @@ var LibraryPThread = {
       transferredCanvasNames = '{{{ OFFSCREENCANVASES_TO_PTHREAD }}}';
     } else
 #endif
-    transferredCanvasNames &&= UTF8ToString(transferredCanvasNames).trim();
-    transferredCanvasNames &&= transferredCanvasNames.split(',');
+    // Note: UTF8ToString(0) will return the empty string.
+    transferredCanvasNames = UTF8ToString(transferredCanvasNames).trim().split(',';
 #if GL_DEBUG
     dbg(`pthread_create: transferredCanvasNames="${transferredCanvasNames}"`);
 #endif