Skip to content

Commit

Permalink
[ci] Add expectations check for PR branch
Browse files Browse the repository at this point in the history
  • Loading branch information
sbc100 committed Dec 19, 2024
1 parent c4ecb13 commit 728e55e
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,32 @@ jobs:
cat $EM_CONFIG
- name: Check test expectations on target branch
run: |
echo "Checking out ${{ github.base_ref }}"
git checkout ${{ github.base_ref }}
git rev-parse HEAD
# Hack to honor changes to rebaseline_tests.py in the current PR
git checkout - ./tools/maint/rebaseline_tests.py
./bootstrap
if ! ./tools/maint/rebaseline_tests.py --check-only; then
echo "Test expectations are out-of-date on the target branch."
echo "You can run `./tools/maint/rebaseline_tests.py --new-branch`"
echo "You can run './tools/maint/rebaseline_tests.py --new-branch'"
echo "and use it to create a seperate PR."
echo "-- This failure is only a warning and can be ignored"
exit 1
fi
- name: Check test expectations on PR branch
run: |
echo "Checking out ${{ github.ref }} (${{ github.sha }})"
# For some reason we cannot pass ${{ github.ref }} direclty to git
# since it doesn't recognise it.
git checkout ${{ github.sha }}
git rev-parse HEAD
./bootstrap
if ! ./tools/maint/rebaseline_tests.py --check-only --clear-cache; then
echo "Test expectations are out-of-date on the PR branch."
echo "You can run './tools/maint/rebaseline_tests.py' to"
echo "create a commit updating the expectations."
echo "Be sure to have `emsdk install tot` first."
echo "-- This failure is only a warning and can be ignored"
exit 1
fi

0 comments on commit 728e55e

Please sign in to comment.