Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate facets provider component to use Composition API #1523

Conversation

andreadlgdo
Copy link
Contributor

@andreadlgdo andreadlgdo commented Jun 17, 2024

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-4315

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@andreadlgdo andreadlgdo self-assigned this Jun 17, 2024
@andreadlgdo andreadlgdo requested a review from a team as a code owner June 17, 2024 13:34
@andreadlgdo andreadlgdo changed the title feat: Migrate facets provider component to use Composition API feat: Migrate facets provider component to use Composition API Jun 17, 2024
@lauramargar lauramargar merged commit eff7b8d into main Jun 19, 2024
4 checks passed
@lauramargar lauramargar deleted the feat/EMP-4315-migrate-facets-provider-component-to-use-composition-API branch June 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants