Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filters in history queries #1315

Merged
merged 13 commits into from
Oct 11, 2023
Merged

feat: filters in history queries #1315

merged 13 commits into from
Oct 11, 2023

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Oct 6, 2023

Pull request template

We want to save filters in history queries. At the moment we are only saving the query and total results, so when you search for a query and apply filters to it, it means that these filters are important in your search. So, why don't we save them? We think that it would be a useful feature for the user.

The idea is to search for a query, apply filters and remove it. Then, if you click on the history query, the search request should contain the query and the filters applied previously.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-2208

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

You can follow these steps:

  • Search for a query
  • Apply filters
  • Remove query
  • Select the same query in the history queries column
  • Check if the filters are applied

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner October 6, 2023 08:25
Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@annacv annacv merged commit 1e266d9 into main Oct 11, 2023
4 checks passed
@diegopf diegopf deleted the feature/EMP-2208-filters-in-hq branch October 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants