Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed - hidden part on pwa when keyboard is open #382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eposha
Copy link

@eposha eposha commented Jun 27, 2024

That solves this issue #255

Copy link

vercel bot commented Jun 27, 2024

@eposha is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.

@fabirydel
Copy link

Any chance this can be prioritized for review? I'm also experiencing this issue

@eposha
Copy link
Author

eposha commented Jul 1, 2024

Any chance this can be prioritized for review? I'm also experiencing this issue

At the moment I have loaded the code from the repository into the project, fixed these few lines and I am importing not from node_modules but from the place where this code is located

I also added these two properties to Drawer.Primitive to prevent the scroll animation bug when closing the keyboard

preventScrollRestoration
disablePreventScroll

@johnstack94
Copy link

This did work when focusing individual inputs, but it doesn't work when we have multiple inputs and switching between them. Either by directly tapping each input or using the keyboard arrows to switch input focus.

Any ideas how to fix this?

@johnstack94
Copy link

Also it doesn't work well with Android devices at all. Much much worse in regard to the whitespace issue along with the panel shrinking and expanding whenever an input is focused. Works better on iOS but still not fixed.

@eposha
Copy link
Author

eposha commented Aug 13, 2024

Also it doesn't work well with Android devices at all. Much much worse in regard to the whitespace issue along with the panel shrinking and expanding whenever an input is focused. Works better on iOS but still not fixed.

Do you use autofocus on input? If yes, you should disable it

Copy link

@Elonmusk678 Elonmusk678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything to normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants