Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 #3

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Python 3 #3

merged 5 commits into from
Aug 9, 2023

Conversation

endolith
Copy link
Contributor

Unfinished attempt at updating it to work. Without pattern compatible with Python 3 it seems like a lot of work to finish though?

#2

@endolith
PEP8
8b91f25 
Imports should be grouped in the following order:

Standard library imports.
Related third party imports.
Local application/library specific imports.

You should put a blank line between each group of imports.
@endolith
Download resources automatically if not installed
0578c07 
Fixes LookupError:
**********************************************************************
  Resource stopwords not found.
  Please use the NLTK Downloader to obtain the resource:

  >>> import nltk
  >>> nltk.download('stopwords')
@endolith
Fix encoding error
549cc1a 
    customStopwords = f.read().split(', ')
                      ^^^^^^^^^^^^^^^^^^^^
TypeError: a bytes-like object is required, not 'str'
@endolith
Update to Python 3
939f92d
@endolith
Workaround for pattern
ca06ad3 
clips/pattern#295 (comment)
emdaniels
emdaniels approved these changes Aug 9, 2023
View reviewed changes
Copy link
Owner

@emdaniels emdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks- I've reviewed the changes and they seem to be an improvement. I haven't had much time to put toward these projects so I appreciate the edits.

@emdaniels emdaniels merged commit 00bc508 into emdaniels:master Aug 9, 2023
@endolith endolith deleted the python_3 branch August 9, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdaniels emdaniels emdaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endolith @emdaniels