Skip to content
This repository has been archived by the owner on Nov 11, 2017. It is now read-only.

Wrap callback to ember run bind #244

Closed

Conversation

AmilKey
Copy link
Contributor

@AmilKey AmilKey commented May 5, 2015

No description provided.

@stefanpenner
Copy link
Member

nope, this one isn't supposed to be wrapped in a bind.

Basically, only very a small subset of the scroll events must actually trigger ember mutations. So we handle that internally.

You are likely observing scrollTop, which is not currently supported.

@AmilKey
Copy link
Contributor Author

AmilKey commented May 6, 2015

@stefanpenner what are scroll events should trigger ember mutations?

@stefanpenner
Copy link
Member

@stefanpenner what are scroll events should trigger ember mutations?

Basically, we only need to enter ember world, when a view is recycled. Although we may receive scroll events extremely often and quickly. We only need to update the scrolling slabs position each scroll event.

Every 1/8 or so scroll events (depending on the scroll rate) we need to recycle views, this is the only time we actually need to enter the run-loop.

Desktop browsers wont notice but some of our slower mobile browsers will notice.

@AmilKey
Copy link
Contributor Author

AmilKey commented May 6, 2015

@stefanpenner ok, i understand you, think one may close pull request.

@stefanpenner
Copy link
Member

@stefanpenner ok, i understand you, think one may close pull request.

Sometime in the future i hope to restore this functionality. Likely as devices get faster, and as ember gets faster :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants