Skip to content
This repository has been archived by the owner on Nov 11, 2017. It is now read-only.

Updated README.md to use EmberCLI semantics #211

Merged
merged 1 commit into from
Apr 5, 2015

Conversation

taras
Copy link
Contributor

@taras taras commented Mar 22, 2015

  • Renamed to Ember List
  • Changed examples to assume EmberCLI
  • Changed installation to use EmberCLI
  • Changed Handlebars examples to use {{ember-list}} helper

@ebryn
Copy link
Member

ebryn commented Mar 22, 2015

Was there a conversation about renaming to "Ember List"?

@taras
Copy link
Contributor Author

taras commented Mar 22, 2015

@stefanpenner and I started talking about releasing the addon and we agreed to publish it on NPM as ember-list. Also, I'm using {{ember-list}} helper in the examples since the View will become increasingly less relevant as approach Ember 2.0.

@ebryn
Copy link
Member

ebryn commented Mar 22, 2015

I'm not really a fan of Ember List, it's too generic sounding. It also supports grids, so list doesn't feel totally right either.

@mmun
Copy link
Member

mmun commented Mar 22, 2015

Agree with @ebryn.

@taras
Copy link
Contributor Author

taras commented Mar 22, 2015

@ebryn I'm with you. We need something other than ListView but I don't know what. Suggestions?

@ebryn
Copy link
Member

ebryn commented Mar 22, 2015

I think we can punt on it a bit longer since it's still a View, and when we need to change it for 2.0 come up with a name potentially better than ListComponent :P

@taras
Copy link
Contributor Author

taras commented Mar 22, 2015

Sure, what about npm package name?

@ebryn
Copy link
Member

ebryn commented Mar 22, 2015

ember-list-view seems fine for now and we can always rename it later?

@taras
Copy link
Contributor Author

taras commented Mar 22, 2015

Ok, but I still want to remove reference to Ember.ListView because that's misleading. Should I just call it ListView in the README?

@ebryn
Copy link
Member

ebryn commented Mar 22, 2015

ListView seems good to me

@taras
Copy link
Contributor Author

taras commented Mar 22, 2015

Ok, I renamed Ember.ListView to ListView and Ember.VirtualListView to VirtualListView.

@tim-evans tim-evans added this to the 0.1.0 milestone Mar 23, 2015
@stefanpenner
Copy link
Member

most of this looks great, 2 things:

  1. `import ListView from 'list-view/list-view' is kinda crappy
  2. should we bike-shed the name ListView now or later? I think ember-list-view or list-view is good, even if it it does a grid, or variable height grids. As it is common to want to display a list-in many ways.

@jonnii
Copy link

jonnii commented Mar 23, 2015

@stefanpenner what about ember-masonry (rim-shot).

@stefanpenner
Copy link
Member

@stefanpenner what about ember-masonry (rim-shot).

heh, maybe once/if we actually support more packing algorithms. Unfortunately writing them in way that supports memorization, that is incremental + bound data structure friendly in a performant way is tricky. But i hope it happens someday :)

@taras
Copy link
Contributor Author

taras commented Mar 23, 2015

`import ListView from 'list-view/list-view' is kinda crappy

Can we do import ListView from 'ember-list-view'?

@stefanpenner
Copy link
Member

Can we do import ListView from 'ember-list-view'?

this would be lovely.

@jonnii
Copy link

jonnii commented Mar 23, 2015

@stefanpenner on a serious note, what about instead of ember-list-view, something like ember-layouts or something like that. I know the plan is to land the packing stuff at some point, and then the name ember-list-view will be just one of the things this does.

@taras
Copy link
Contributor Author

taras commented Mar 23, 2015

@stefanpenner I don't know how to do that with EmberCLI. Can you give me a hint and I'll figure it out from there?

I asked @rwjblue about this before and he said: "That's not how ES6 modules work." and then went and did it for Pretender import Pretender from 'pretender' 😯

@stefanpenner
Copy link
Member

actually its kinda crappy, @joliss had a good idea but we haven't implemented it yet. For now it actually uses the re-exporter. https://github.com/ember-cli/ember-cli/blob/e38e6d8a65b9977ad3f51bbf57336deb77f2fd56/lib/models/addon.js#L472

- Renamed  to *Ember List*
- Changed examples to assume EmberCLI
- Changed installation to use EmberCLI
- Changed Handlebars examples to use {{ember-list}} helper

Changed List View to ListView

Changed title of the readme

Changed Ember Virtual List ->  VirtualListView

Updated example to use {{view 'list-view'}} instead of {{ember-list}}
@taras taras force-pushed the modernize-readme branch from 5cd14e9 to 28d9c69 Compare March 25, 2015 17:05
@taras taras mentioned this pull request Apr 5, 2015
@stefanpenner stefanpenner merged commit 28d9c69 into emberjs:master Apr 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants