Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop storing items in tmp/ directory, only copy bundled ember when no over-ride present #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexblom
Copy link

Every time Rails is initialized, ember-rails copies ember & ember-data from the local gem to tmp/ember-rails. When a user runs the ember-rails updater, versions are stored in /vendor/assets. If the user updates their ember gems instead, updated ember copies are placed in tmp/.

Changes:

  1. Move the /tmp folder to a /bundled in the ember assets folder. This serves the same purpose, but means the gem only ever copies ember to one spot. (No more rake tmp:clear / updated versions in potentially 2 places)
  2. Make sure there is no updated/over-ride copy of ember, and only copy the if there is none (no duplicates).

Fixes #343 & possibly issues from #345.

only copy ember from gem when local over-ride / update not present
@tomash
Copy link

tomash commented May 8, 2014

that'd help us a lot, especially given different permission systems than what's usually done with capistrano (don't ask). 👍

@CloCkWeRX
Copy link

Oops, wrong bug/pull request.

I'm actually finding that even when I do

bundle exec rake -T I'm getting a tmp/ directory created. If I do it as the wrong user, all of a sudden I end up with an application that won't start.

I don't think that simply loading the gem should start modifying the system. +1 to this pull to stop tmp being created, but it would be better to have this as an explicit action, not an implicit one.

@alexblom
Copy link
Author

Thanks tomash and CloCkWeRX.

I don't really use Ember Rails anymore (moved to cli around the time of this commit) - would it be useful for me to update this pr to not have conflicts?

@CloCkWeRX
Copy link

Yes please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ember:install generator should clear tmp files after installing.
3 participants