refactor: use glimmer component for search-input #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kennstenicht
force-pushed
the
refactor-search-input
branch
2 times, most recently
from
571bf94 to
9a4efb1
Compare
kennstenicht
force-pushed
the
refactor-search-input
branch
from
9a4efb1 to
126835b
Compare
kennstenicht
commented
Aug 12, 2024
| Try searching the | ||
| <a | ||
| href={{this.deprecationsGuideURL}} | ||
| target="_deprecations" |
There was a problem hiding this comment.
@mansona is target="_deprecations" a special guidemaker target?
There was a problem hiding this comment.
no this isn't something I'm aware of 😂 We can probably remove it 🤷
mansona
reviewed
Aug 13, 2024
|
|
||
| set(this, '_focused', false); | ||
| }), | ||
| closeMenu = task({ restartable: true }, async () => { |
There was a problem hiding this comment.
it looks like you might have put the restartable on the closeMenu task instead of the search task 🤔
mansona
reviewed
Aug 13, 2024
test-app/package.json
Outdated
| @@ -47,6 +47,7 @@ | |||
| "ember-cli-inject-live-reload": "^2.1.0", | |||
| "ember-cli-sri": "^2.1.1", | |||
| "ember-cli-terser": "^4.0.2", | |||
| "ember-concurrency": "^4.0.0", | |||
There was a problem hiding this comment.
why is this necessary? is it not a a dependency of the actual addon already? 🤔
driesdl
reviewed
Sep 4, 2024
| autocomplete="off" | ||
| data-test-search-input | ||
| {{on "focus" this.onfocus}} | ||
| {{on "blur" (perform this.closeMenu)}} |
There was a problem hiding this comment.
Is using 'perform' the standard in this project? To explicitly indicate the action?
In the line above it's commenly written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the same procedure as last time. The first commit is formatting the files and the second is the refactoring.