style: update "on this page" to only show headers up until level 3 and indent #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IgnaceMaes
commented
Feb 19, 2024
| <li> | ||
| <a href="#{{toc.id}}">{{toc.text}}</a> | ||
| </li> | ||
| {{#if (or (eq toc.depth '1') (eq toc.depth '2') (eq toc.depth '3'))}} |
There was a problem hiding this comment.
This is pretty verbose, but keeps the component a TOC. Depth is passed as string, and changing that to a number would have a bigger impact and be outside of scope of this repo?
There was a problem hiding this comment.
I'm happy with it as it is 👍 if you wanted to make this a helper like (should-show-toc-depth) then you could absorb the string/number issue there, but that's not necessary 👍
IgnaceMaes
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #179
To be fair, this example doesn't properly showcase the real difference, and a real content page would be better suited to test.
EDIT: test using the Template Tag Format content: