Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: on-this-page tweaks #174

Merged
merged 3 commits into from
Feb 19, 2024
Merged

style: on-this-page tweaks #174

merged 3 commits into from
Feb 19, 2024

Conversation

IgnaceMaes
Copy link
Member

Styling tweaks for the sidebar. Adds more visual distinction between the guide content and the sidebar.

Before After

sidebar-before

sidebar-after

@netlify Netlify
Copy link

netlify bot commented Feb 3, 2024 •
edited
Loading

✅ Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit e359c78
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/65beaabca96e970008fb1fb2
😎 Deploy Preview https://deploy-preview-174--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MinThaMie MinThaMie changed the title style: sidebar tweaks style: on-this-page tweaks Feb 15, 2024
mansona
mansona approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant improvement 🎉 we discussed adding the "depth" information into the design but that is going to follow as a new PR 👍

@mansona mansona added the enhancement New feature or request label Feb 19, 2024
@mansona mansona merged commit e297ca4 into ember-learn:main Feb 19, 2024
12 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Merged
@IgnaceMaes IgnaceMaes mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgnaceMaes @mansona