cleanup: remove redundant toc styles #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The |
lukasnys
force-pushed
the
remove-toc-styling
branch
from
77061b7 to
c0ab786
Compare
added 2 commits
February 5, 2024 11:44
these styles were added to ember-styleguide in ember-learn/ember-styleguide@add121d
lukasnys
force-pushed
the
remove-toc-styling
branch
from
c0ab786 to
237d6fe
Compare
Done! |
|
LGTM, but a second quick review would be nice as I'm not 100% up to speed with the style guide changes. |
IgnaceMaes
approved these changes
Feb 7, 2024
This was referenced Mar 1, 2024
|
the whole file was deleted in #171 so we can close this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the table-of-contents styles were added into ember-styleguide (ember-learn/ember-styleguide@add121d) but they were also still in guidemaker-ember-template.
[email protected]as this version removes the peer dependency of ember-styleguideAs described in the 9.0.0 release notes, support for Ember<3.28 and Node<18.0 was dropped, but in Guidemaker we're on [email protected] and node@18 so this shouldn't impact us.