refactor: clearer var names

ember-learn · Feb 22, 2024 · bfdf974 · bfdf974
1 parent 18734e0
commit bfdf974
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/addon/modifiers/highlight-active-title.js b/addon/modifiers/highlight-active-title.js
@@ -1,17 +1,14 @@
 import { modifier } from 'ember-modifier';
 
 export default modifier(function highlightActiveTitle(element, [toc]) {
-  const observer = new IntersectionObserver((entries) => {
-    entries.forEach((entry) => {
-      const id = entry.target.getAttribute('aria-labelledby');
-      if (entry.intersectionRatio > 0) {
-        element
-          .querySelector(`a[href="#${id}"]`)
-          ?.parentElement.classList.add('in-viewport');
+  const observer = new IntersectionObserver((tocSections) => {
+    tocSections.forEach((tocSection) => {
+      const tocId = tocSection.target.getAttribute('aria-labelledby');
+      const tocHeader = element.querySelector(`a[href="#${tocId}"]`);
+      if (tocSection.intersectionRatio > 0) {
+        tocHeader?.parentElement.classList.add('in-viewport');
       } else {
-        element
-          .querySelector(`a[href="#${id}"]`)
-          ?.parentElement.classList.remove('in-viewport');
+        tocHeader?.parentElement.classList.remove('in-viewport');
       }
     });
   });