chore: update lint

.eslintrc

@@ -5,16 +5,21 @@
   "rules": {
     "import/default": "off",
     "import/no-unresolved": "off", // to capture direct deps in TS
+    "import/no-default-export": "off",
     "no-dupe-class-members": "off", // to enable TS overload
     "no-undef": "off", //FIXME @see https://github.com/eslint/typescript-eslint-parser/issues/75
     "import/named": "off", //FIXME @see https://github.com/eslint/typescript-eslint-parser/issues/75
     "no-unused-expressions": "off", // tests
     "react/sort-comp": "off",
     "react/prop-types": "off",
+    "prefer-const": "warn",
+    "sonarjs/no-nested-template-literals": "off",
+    "ringcentral/specified-comment-with-task-id": "off",
     "@typescript-eslint/camelcase": "off", // OAuth responses
     "@typescript-eslint/no-unused-vars": "off",
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/no-var-requires": "off" // conditional require in Externals
   },
   "env": {

package.json

@@ -40,8 +40,8 @@
   "dependencies": {
     "coveralls": "^3.1.1",
     "dotenv-cli": "^1.4.0",
-    "eslint": "^5.8.0",
-    "eslint-config-ringcentral-typescript": "0.1.0",
+    "eslint": "^8.52.0",
+    "eslint-config-ringcentral-typescript": "^7.0.3",
     "husky": "^1.1.3",
     "lerna": "^6.6.2",
     "lint-staged": "^12.5.0",

react-demo/src/Dashboard.tsx

@@ -22,8 +22,8 @@ export default class Dashboard extends Component<any, DashboardState> {
 
     public render() {
         const {error, user} = this.state;
-        if (error) return <div>{error}</div>;
-        if (!user) return <div>Loading</div>;
+        if (error) {return <div>{error}</div>;}
+        if (!user) {return <div>Loading</div>;}
         return <pre>{JSON.stringify(user, null, 2)}</pre>;
     }
 }

react-demo/src/Login.tsx

@@ -3,7 +3,7 @@ import {withAuthGate} from '@ringcentral/react';
 import {sdk} from './lib';
 
 const Login = ({authError, loginUrl, authorizing}: any) => {
-    if (authorizing) return <div>Loading...</div>;
+    if (authorizing) {return <div>Loading...</div>;}
 
     const login = () => window.location.assign(loginUrl({implicit: true}));
 

react-demo/src/index.tsx

@@ -4,4 +4,4 @@ import Router from './Router';
 
 render(<Router />, document.getElementById('app'));
 
-if (module.hot) module.hot.accept();
+if (module.hot) {module.hot.accept();}

react/src/AuthGate.tsx

@@ -1,4 +1,5 @@
 import React, {Component} from 'react';
+
 import {SDK} from '@ringcentral/sdk';
 
 function getDisplayName(WrappedComponent) {
@@ -32,6 +33,11 @@ export class AuthGate extends Component<AuthGateProps, AuthGateState> {
         authError: null,
     };
 
+    // default props
+    public static defaultProps = {
+        ensure: false,
+    };
+
     /**
      * purposely going through antipattern because we can't cancel promises for now
      * we still cancel subscriptions etc., but we can't guarantee when storage promises will resolve
@@ -93,7 +99,7 @@ export class AuthGate extends Component<AuthGateProps, AuthGateState> {
         try {
             const platform = this.props.sdk.platform();
             const loginOptions = platform.parseLoginRedirect(search);
-            if (!loginOptions.code && !loginOptions.access_token) throw new Error('No authorization information');
+            if (!loginOptions.code && !loginOptions.access_token) {throw new Error('No authorization information');}
             return platform.login(loginOptions);
         } catch (e) {
             await this.error(e);

redux-demo/src/index.tsx

@@ -8,4 +8,4 @@ const store = createStore();
 
 render(<Router store={store} storeConnector={storeConnector} />, rootEl);
 
-if (module.hot) module.hot.accept();
+if (module.hot) {module.hot.accept();}

redux-demo/src/pages/Index.tsx

@@ -31,9 +31,9 @@ class Index extends Component<any, IndexState> {
     public render() {
         const {error, user} = this.state;
 
-        if (error) return <div>Error: {error.toString()}</div>;
+        if (error) {return <div>Error: {error.toString()}</div>;}
 
-        if (!user) return <div>Loading...</div>;
+        if (!user) {return <div>Loading...</div>;}
 
         return (
             <div>

redux-demo/src/pages/Login.tsx

@@ -9,7 +9,7 @@ export interface LoginProps extends RouteComponentProps {
     error: null | Error;
 }
 
-let Login: FunctionComponent<LoginProps> = ({error, location: {pathname, search, hash}}) => {
+const Login: FunctionComponent<LoginProps> = ({error, location: {pathname, search, hash}}) => {
     const query = sdk.parseLoginRedirect(search || hash);
 
     // code is defined in redirect from OAuth

redux/src/actions.ts

@@ -13,7 +13,7 @@ export default class Actions {
     }
 
     public login = query => {
-        if (query.error_description) return this.authError(new Error(query.error_description));
+        if (query.error_description) {return this.authError(new Error(query.error_description));}
         this.sdk.login(query); // we ignore promise result because we listen to all events already
         return {type: LOGIN};
     };

sdk/src/core/Cache.ts

@@ -37,7 +37,7 @@ export default class Cache {
 
     public getItemSync(key) {
         const item = this._externals.localStorage.getItem(this._prefixKey(key));
-        if (!item) return null;
+        if (!item) {return null;}
         return JSON.parse(item);
     }
 

sdk/src/core/Externals.ts

@@ -31,11 +31,11 @@ export default class Externals implements ExternalsOptions {
         Headers: HeadersImpl,
         localStorage,
     }: ExternalsOptions = {}) {
-        if (fetchImpl) this.fetch = fetchImpl;
-        if (RequestImpl) this.Request = RequestImpl;
-        if (ResponseImpl) this.Response = ResponseImpl;
-        if (HeadersImpl) this.Headers = HeadersImpl;
-        if (localStorage) this.localStorage = localStorage;
+        if (fetchImpl) {this.fetch = fetchImpl;}
+        if (RequestImpl) {this.Request = RequestImpl;}
+        if (ResponseImpl) {this.Response = ResponseImpl;}
+        if (HeadersImpl) {this.Headers = HeadersImpl;}
+        if (localStorage) {this.localStorage = localStorage;}
 
         /* istanbul ignore next */
         if (!this.fetch || !this.Response || !this.Request || !this.Headers) {

sdk/src/http/Client.ts

@@ -6,8 +6,8 @@ import Externals from '../core/Externals';
 function findHeaderName(name, headers) {
     name = name.toLowerCase();
     return Object.keys(headers).reduce((res, key) => {
-        if (res) return res;
-        if (name === key.toLowerCase()) return key;
+        if (res) {return res;}
+        if (name === key.toLowerCase()) {return key;}
         return res;
     }, null);
 }
@@ -75,7 +75,7 @@ export default class Client extends EventEmitter {
 
             response = await this._loadResponse(request);
 
-            if (!response.ok) throw new Error('Response has unsuccessful status');
+            if (!response.ok) {throw new Error('Response has unsuccessful status');}
 
             this.emit(this.events.requestSuccess, response, request);
 
@@ -113,8 +113,8 @@ export default class Client extends EventEmitter {
         init.headers = init.headers || {};
 
         // Sanity checks
-        if (!init.url) throw new Error('Url is not defined');
-        if (!init.method) init.method = 'GET';
+        if (!init.url) {throw new Error('Url is not defined');}
+        if (!init.method) {init.method = 'GET';}
         init.method = init.method.toUpperCase();
         if (init.method && Client._allowedMethods.indexOf(init.method) < 0) {
             throw new Error(`Method has wrong value: ${init.method}`);
@@ -183,13 +183,13 @@ export default class Client extends EventEmitter {
     }
 
     public async multipart(response: Response): Promise<Response[]> {
-        if (!this.isMultipart(response)) throw new Error('Response is not multipart');
+        if (!this.isMultipart(response)) {throw new Error('Response is not multipart');}
 
         // Step 1. Split multipart response
 
         const text = await response.text();
 
-        if (!text) throw new Error('No response body');
+        if (!text) {throw new Error('No response body');}
 
         let boundary;
 
@@ -199,14 +199,14 @@ export default class Client extends EventEmitter {
             throw new Error('Cannot find boundary');
         }
 
-        if (!boundary) throw new Error('Cannot find boundary');
+        if (!boundary) {throw new Error('Cannot find boundary');}
 
         const parts = text.toString().split(Client._boundarySeparator + boundary);
 
-        if (parts[0].trim() === '') parts.shift();
-        if (parts[parts.length - 1].trim() === Client._boundarySeparator) parts.pop();
+        if (parts[0].trim() === '') {parts.shift();}
+        if (parts[parts.length - 1].trim() === Client._boundarySeparator) {parts.pop();}
 
-        if (parts.length < 1) throw new Error('No parts in body');
+        if (parts.length < 1) {throw new Error('No parts in body');}
 
         // Step 2. Parse status info
 
@@ -234,7 +234,7 @@ export default class Client extends EventEmitter {
             const key = split.shift().trim();
             const value = split.join(Client._headerSeparator).trim();
 
-            if (key) headers.append(key, value);
+            if (key) {headers.append(key, value);}
         });
 
         return new this._externals.Response(text, {
@@ -245,16 +245,16 @@ export default class Client extends EventEmitter {
     }
 
     public async error(response: Response, skipOKCheck = false): Promise<string> {
-        if (response.ok && !skipOKCheck) return null;
+        if (response.ok && !skipOKCheck) {return null;}
 
         let msg = (response.status ? `${response.status} ` : '') + (response.statusText ? response.statusText : '');
 
         try {
             const {message, error_description, description} = await response.clone().json();
 
-            if (message) msg = message;
-            if (error_description) msg = error_description;
-            if (description) msg = description;
+            if (message) {msg = message;}
+            if (error_description) {msg = error_description;}
+            if (description) {msg = description;}
         } catch (e) {} //eslint-disable-line
 
         return msg;

sdk/src/platform/Discovery.ts

@@ -124,16 +124,16 @@ export default class Discovery extends EventEmitter {
     private _externalFetchPromise?: Promise<ExternalDiscoveryData>;
     private _externalRefreshPromise?: Promise<void>;
 
-    private _initialized: boolean = false;
+    private _initialized = false;
 
     private _refreshHandicapMs: number;
     private _refreshDelayMs: number;
 
-    private _initialRetryCount: number = 0;
+    private _initialRetryCount = 0;
     private _initialRetryMaxCount: number;
     private _initialRetryInterval: number;
 
-    private _externalRetryCount: number = 0;
+    private _externalRetryCount = 0;
     private _externalRetryMaxCount: number;
     private _externalRetryInterval: number;
     private _externalRetryCycleTimeout?: ReturnType<typeof setTimeout> = null;
@@ -344,7 +344,7 @@ export default class Discovery extends EventEmitter {
         }
         await this._cache.setItem(this._externalCacheId, {
             ...newData,
-            expireTime: expireTime,
+            expireTime,
         });
     }
 

sdk/src/platform/Platform-spec.ts

@@ -1121,7 +1121,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/initial?clientId=whatever', {description: 'Fail'}, 500);
             apiCall('GET', '/.well-known/entry-points/initial?clientId=whatever', {description: 'Fail'}, 500);
             apiCall('GET', '/.well-known/entry-points/initial?clientId=whatever', {description: 'Fail'}, 500);
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             const requestErrorSpy = spy(() => {});
             sdk.client().on(sdk.client().events.requestError, requestErrorSpy);
@@ -1147,7 +1147,7 @@ describe('RingCentral.platform.Platform', () => {
         it('should fetch initial discovery on loginUrlWithDiscovery', async () => {
             const initialDiscoveryData = getInitialDiscoveryMockData();
             apiCall('GET', '/.well-known/entry-points/initial?clientId=whatever', initialDiscoveryData);
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             expect(
                 (await platform.loginUrlWithDiscovery()).indexOf(initialDiscoveryData.authApi.authorizationUri),
@@ -1157,7 +1157,7 @@ describe('RingCentral.platform.Platform', () => {
         it('should not throw error when fetch initial discovery error with cache data on loginUrlWithDiscovery', async function() {
             const initialDiscoveryData = getInitialDiscoveryMockData();
             apiCall('GET', '/.well-known/entry-points/initial?clientId=whatever', initialDiscoveryData);
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             if (platform.discoveryInitPromise) {
                 await platform.discoveryInitPromise;
@@ -1173,7 +1173,7 @@ describe('RingCentral.platform.Platform', () => {
         it('should throw error when fetch initial discovery error without cache data on loginUrlWithDiscovery', async function() {
             const initialDiscoveryData = getInitialDiscoveryMockData();
             apiCall('GET', '/.well-known/entry-points/initial?clientId=whatever', initialDiscoveryData);
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             if (platform.discoveryInitPromise) {
                 await platform.discoveryInitPromise;
@@ -1199,7 +1199,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/external', externalDiscoveryData);
             authentication();
 
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             await platform.login({
                 code: 'whatever',
@@ -1219,7 +1219,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/external', externalDiscoveryData);
             authentication();
 
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             await platform.login({
                 code: 'whatever',
@@ -1239,7 +1239,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/external', externalDiscoveryData);
             authentication();
 
-            const sdk = createSdk({
+            sdk = createSdk({
                 enableDiscovery: true,
                 discoveryServer: 'http://whatever',
                 discoveryAutoInit: false,
@@ -1262,7 +1262,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/external', externalDiscoveryData);
             authentication();
 
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             await platform.login({code: 'whatever'});
             const externalData = await platform.discovery().externalData();
@@ -1279,7 +1279,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/external', externalDiscoveryData);
             authentication();
 
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             await platform.login({
                 code: 'whatever',
@@ -1301,7 +1301,7 @@ describe('RingCentral.platform.Platform', () => {
             apiCall('GET', '/.well-known/entry-points/external', null, 500);
             authentication();
 
-            const sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
+            sdk = createSdk({enableDiscovery: true, discoveryServer: 'http://whatever', server: ''});
             const platform = sdk.platform();
             const clientFetchErrorSpy = spy(() => {});
             sdk.client().on(sdk.client().events.requestError, clientFetchErrorSpy);