fix occasional errors we see when generating a uuid using uuid library by switching to securerandom #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from emailage/master
…y by switching to securerandom
fix occasional errors we see when generating a uuid using uuid library by switching to securerandom
… body is blank bc we see this happen occasionally and want to be able to catch this particular scenario
raise TemporaryError if we do not receive a 200 response code and the body is blank
Add customised exception if response is empty from emailage.
Log body if emailage api returns no json body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally get
NoMethodError'undefined method unpack' for nil:NilClasswhen generating a UUID using theuuidgem. Others are reporting similar issues: assaf/uuid#28 . The workaround was to useSecureRandominstead