Add @ember/test-helpers v3 ember-try scenario

elwayman02 · Aug 26, 2024 · 1ac0851 · 1ac0851
1 parent 35e80bb
commit 1ac0851
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -56,6 +56,7 @@ jobs:
           - ember-lts-4.8
           - ember-lts-4.12
           - ember-lts-5.4
+          - ember-test-helpers-v3
           - ember-release
           - embroider-safe
         experimental: [false]

diff --git a/package.json b/package.json
@@ -38,11 +38,12 @@
     "intersection-observer-admin": "^0.3.4"
   },
   "peerDependencies": {
-    "@ember/test-helpers": "^3.0.0 || ^4.0.0"
+    "@ember/test-helpers": "^3.0.0 || ^4.0.0",
+    "ember-source": "^4.0.0 || ^5.0.0"
   },
   "peerDependenciesMeta": {
     "@ember/test-helpers": {
-      "optional": false
+      "optional": true
     }
   },
   "devDependencies": {
@@ -101,9 +102,6 @@
   "fastbootDependencies": [
     "crypto"
   ],
-  "peerDependencies": {
-    "ember-source": "^4.0.0 || ^5.0.0"
-  },
   "engines": {
     "node": "16.* || >= 18"
   },

diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js
@@ -39,6 +39,14 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'ember-test-helpers-v3',
+        npm: {
+          devDependencies: {
+            '@ember/test-helpers': '^3.3.1',
+          },
+        },
+      },
       {
         name: 'ember-release',
         npm: {