Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embroider compatible with dynamic components #817

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Embroider compatible with dynamic components #817

merged 1 commit into from
Oct 11, 2023

Conversation

hexadecy
Copy link
Contributor

  • Workaround for Embroider test
ERROR in ../../node_modules/field-guide/templates/components/dynamic-template.hbs
Module build failed (from ../../../../../home/runner/work/ember-resize-modifier/ember-resize-modifier/node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
$TMPDIR/embroider/6678d4/node_modules/field-guide/templates/components/dynamic-template.hbs: Unsafe dynamic component: this.componentName in $TMPDIR/embroider/6678d4/node_modules/field-guide/templates/components/dynamic-template.hbs

 @ ../../node_modules/field-guide/components/dynamic-template.js 5:0-62 13:2-8
 @ ./components/dynamic-template.js 2:0-88 2:0-88
 @ ../../node_modules/field-guide/templates/show.hbs 2:0-82 13:30-45
 @ ./templates/show.js 1:0-75 1:0-75
 @ ./assets/dummy.js 63:13-44

This PR in field-guide should fix the issue:
Support Embroider

@elwayman02 elwayman02 merged commit a38bc67 into elwayman02:master Oct 11, 2023
14 checks passed
@elwayman02 elwayman02 added bug Something isn't working internal labels Oct 11, 2023
elwayman02 added a commit to elwayman02/ember-scroll-modifiers that referenced this pull request Oct 11, 2023
@elwayman02
Fix embroider builds
be1b830 
See: elwayman02/ember-resize-modifier#817
@elwayman02 elwayman02 mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hexadecy @elwayman02