Skip to content

Commit

Permalink
tidy comment
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewpatto committed Oct 3, 2023
1 parent 3720c53 commit 227d77d
Showing 1 changed file with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@ import { ContainerConstruct } from "../construct/container-construct";
import { IHostedZone } from "aws-cdk-lib/aws-route53";
import { ICertificate } from "aws-cdk-lib/aws-certificatemanager";

//
// WIP warning
// was used to test the concept
// waiting on a CDK construct for settings the deployed URL and then we should revisit
// THIS GETS SLOWLY OUT OF DATA WITH THE REAL APPLICATION CONSTRUCT - SO PLEASE DO A CHECK FOR CHANGES THERE
// AND IMPLEMENT HERE
//

interface Props extends ElsaDataApplicationSettings {
readonly vpc: ec2.IVpc;

Expand Down Expand Up @@ -62,8 +54,8 @@ export class ElsaDataApplicationAppRunnerConstruct extends Construct {

// we need to give the Vpc Connector a security group that allows outward traffic
// so that we can make AWS calls
// the VPC connector would normally make this for us by default - but because we *als* want
// to specify a edgedb security group - we must do it manually and set both
// the VPC connector would normally make this for us by default - but because we *also* want
// to specify an edgedb security group - we must do it manually and set both
const appSecurityGroup = new SecurityGroup(this, "AppRunnerSecurityGroup", {
vpc: props.vpc,
allowAllOutbound: true,
Expand Down

0 comments on commit 227d77d

Please sign in to comment.