breadcrumbsNumber: 0 - 25

elmahio · Jan 12, 2022 · 03bb6f6 · 03bb6f6
1 parent 79ec577
commit 03bb6f6
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 15 deletions.
diff --git a/dist/elmahio.js b/dist/elmahio.js
diff --git a/dist/elmahio.js.map b/dist/elmahio.js.map
diff --git a/dist/elmahio.min.js b/dist/elmahio.min.js
diff --git a/dist/elmahio.min.js.map b/dist/elmahio.min.js.map
diff --git a/elmah.io.javascript.nuspec b/elmah.io.javascript.nuspec
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
   <metadata>
-    <version>3.5.4</version>
+    <version>3.6.0</version>
     <authors>elmah.io</authors>
     <owners>elmah.io</owners>
     <id>elmah.io.javascript</id>

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "elmah.io.javascript",
   "description": "elmah.io javascript logger.",
-  "version": "3.5.4",
+  "version": "3.6.0",
   "repository": "https://github.com/elmahio/elmah.io.javascript",
   "license": "Apache-2.0",
   "main": "dist/elmahio.js",

diff --git a/src/elmahio.js b/src/elmahio.js
@@ -1,5 +1,5 @@
 /*!
- * elmah.io Javascript Logger - version 3.5.4
+ * elmah.io Javascript Logger - version 3.6.0
  * (c) 2018 elmah.io, Apache 2.0 License, https://elmah.io
  */
 
@@ -1116,15 +1116,15 @@
 
             breadcrumbs.push(crumb);
 
-            if(options.breadcrumbsNumber && typeof options.breadcrumbsNumber === "number" ) {
+            if(options.breadcrumbsNumber >= 0 && typeof options.breadcrumbsNumber === "number" ) {
                 if(options.breadcrumbsNumber > 25) {
                     breadcrumbs_number = 25;
-                } else if(options.breadcrumbsNumber >= 10 && options.breadcrumbsNumber <= 25) {
+                } else if(options.breadcrumbsNumber <= 25) {
                     breadcrumbs_number = options.breadcrumbsNumber;
                 }
             }
 
-            if (breadcrumbs.length >= breadcrumbs_number) {
+            if (breadcrumbs.length > breadcrumbs_number) {
                 breadcrumbs.shift();
             }
         }

diff --git a/typescript/elmahio.d.ts b/typescript/elmahio.d.ts
@@ -101,7 +101,7 @@ declare namespace Elmahio {
         breadcrumbs?: boolean;
         /**
          * Number of breadcrumbs to log.
-         * Minimum 10, maximum 25 breadcrumbs.
+         * Maximum 25 breadcrumbs.
          */
         breadcrumbsNumber?: number;
     }