Add rest of Waypoint schema elements + tests #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
things added+fixed
cmtto the Waypoint creation step in gpxParse so that a comment in the waypoint XML is associated with the new GpxWaypoint.Linksfield — please make sure it is implemented how you envision it. Now it returns an empty array[]if no links are present, else an array of objects with keyssrc, text, type. It allows for missing values for any of these fields, returning in this case an empty string"".oops
I squashed commits from the previous PR and filed a new one to clean things up, hence the slight duplication. Sorry about the git messiness.
closes #25