Report correct error for value lists in joins #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the case of `create_name`, then third param may be a string or atom prefix ... and in those cases should be treated as a prefix. however syntax such as `VALUES (...)` will pass in the values list information as the third tuple. this was causing spurious exceptions to be thrown, rather than creating the correct table name
This improves the error messages for `JOIN VALUES (...) AS` clauses which were being mistakenly tagged as a table prefixing issue. Now the user gets a more accurate message. It also puts all the join syntax checking into a single function which makes it a bit eaiser to reason about (e.g. that hints, values, etc. are not OK, but other join constructs are)
|
There may be value in supporting |
|
If there is interest in supporting |
|
The juice may not be worth the squeeze at the moment. Let's put a pin in it. I released this fix under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #138
The wrong error was being thrown due to the third param in the source passed into
create_nameis only a binary when its a prefix, while other SQL syntax passes in other terms as the third parameter.JOIN VALUES((...),(...)) ASclauses pass in a{values, index, number_of_values}tuple as the third parameter, for instance.So this fix is in two parts: one fixes
quote_tableto account for this, the other introduces anassert_valid_jointhat validates joins, generating consistent, clear errors as needed.Note: I did actually attempt to implement
VALUES()joins .. however, while SQLITE does support theVALUES()syntax, it does not work meaningfully in joins, as it does not support column aliases on tables, meaning there is no way to name the columns in the values list (as Ecto provides for), and as such no way to use a values list as a join table. I did get the actualVALUESlist to be accepted by sqlite's query parser, though ... but that turned out to be for not due to these other limitations in the engine. Ah well ...