test: ensure Loop.checkpoint reacts to event filter #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
commented
Aug 15, 2023
Comment on lines
+802
to
+806
| "checkpoint_0_2.ckpt", | ||
| "checkpoint_0_4.ckpt", | ||
| "checkpoint_1_1.ckpt", | ||
| "checkpoint_1_3.ckpt", | ||
| "checkpoint_2_0.ckpt", |
There was a problem hiding this comment.
@seanmor5 looks like checkpointing does work (probably I did something wrong on my end). Though I didn't expect the event count (and thus the filter) for iterations to be a total tally over the whole run. Is this expected?
There was a problem hiding this comment.
I think it should be a tally over the whole run, because that's the total number of times the event fires. Maybe it's more clear the other way though, but I think either way you slice it it might be confusing
There was a problem hiding this comment.
Right. I can see the argument for both. Just wanted to make sure this is the expected format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.