Revert "Allow numbers in literal/1 (#4562)" and add identifier/1 and constant/1 instead #4563
+101
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussions, it seems there is agreement that the old
literal/1
should be deprecated and we should make two new "functions": one for identifiers and one for constant values.There was agreement by some people for
identifier/1
andconstant/1
. If you are not in favour of those names let me know! It won't affect the PR much.Also, I'm not sure what is the normal deprecation procedure. I think we need to keep accepting
literal/1
to not break apps? If so should we remove it from the documentation or put some notes in the documentation about it being deprecated and replaced by these 2?Companion Ecto SQL PR: elixir-ecto/ecto_sql#652