Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a discussion where someone was using a database that does not allow query parameters in limit expressions but it's still desirable to have dynamic limit values. The simplest thing I can think of is to expand
literal/1
to also allow numbers.Some other considerations that I did not pursue:
literal/1
(quoting identifiers). Also we probably don't want to encourage using this too much as it may blow up the Ecto cache.literal/2
or something like that. I'm not sure it is worth it since the use cases are pretty limited.Companion Ecto SQL PR: elixir-ecto/ecto_sql#651