ELPP-3573 Resolve content header list wrapping #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge the latest |
thewilkybarkid
commented
Apr 5, 2018
| @@ -121,13 +121,15 @@ | |||
| <ol class="content-header__author_list"> | |||
| {{#authors.list}} | |||
| <li class="content-header__author_list_item"> | |||
| <span class="content-header__author">{{#url}}<a href="{{url}}" data-behaviour="Popup" class="content-header__author_link">{{/url}}{{name}}{{#url}}</a>{{/url}}{{#isCorresponding}} | |||
| <picture> | |||
| <span class="content-header__author">{{#url}}<a href="{{url}}" data-behaviour="Popup" class="content-header__author_link">{{/url}}{{name}}{{#url}}</a>{{/url}}{{#isCorresponding}} {{! | |||
There was a problem hiding this comment.
Can still recreate the original problem, looks like doesn't fix non-text?
There was a problem hiding this comment.
thewilkybarkid
changed the title
|
@giorgiosironi The S3 deploy doesn't seem to have the changes. I though #847 might solve the problem but apparently not. |
|
Seems that the problem is Lines 25 to 27 in 98748e5 |
This reverts commit 98748e5.
thewilkybarkid
commented
Apr 10, 2018
docker-compose.yml
Outdated
| @@ -13,6 +13,8 @@ services: | |||
| build: | |||
| context: . | |||
| dockerfile: Dockerfile | |||
| args: | |||
| commit: ${IMAGE_TAG} | |||
There was a problem hiding this comment.
@giorgiosironi This seems to be the fix (not setting means it always gets the latest assets).
There was a problem hiding this comment.
Extracted into #849.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal is to stop the corresponding author icon from wrapping:
But I've also spotted that the expander can wrap:
And the last-non-excess institution misses its separator:
Making the icon not wrap isn't hard, but the CSS-introduced comma is problematic. So, I'm thinking that it should be in the HTML (as ARIA hidden) and shown/displayed as appropriate.
(I've applied it to institutions as well even though they don't have the icon and can probably get away with it, for consistency.)