[WIP] Start fixing side-by-side view position #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
commented
Jan 26, 2018
| top: (40px + 1 + 54 + 40); // .site-header height + .side-by-side-view__bar height | ||
| top: #{get-rem-from-px(40 + 1 + 54 + 40)}rem; | ||
| height: calc(100% - #{(40 + 1 + 54)}px - 40px); // 100% - .site-header height - .side-by-side-view__bar height | ||
| height: calc(100% - #{get-rem-from-px(40 + 1 + 54)}rem - #{get-rem-from-px(40)}rem); |
There was a problem hiding this comment.
Works, but stylelint isn't happy.
thewilkybarkid
commented
Jan 26, 2018
| @@ -1,7 +1,7 @@ | |||
| @import "../../definitions"; | |||
|
|
|||
| .site-header { | |||
| max-height: 96px; | |||
| /*max-height: 96px;*/ | |||
There was a problem hiding this comment.
Don't think this is needed?
Merged
|
@thewilkybarkid I'm closing this for now as it has been sitting here for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The side-by-side view isn't positioned correctly, this is due to a mix on rems and px in the site header:
This is a start on trying to make it all rem-compatible.