Downgrade prc-pub-review-test-1 to warning

elifesciences · Nov 27, 2023 · b6f4c5f · b6f4c5f
1 parent 90b2411
commit b6f4c5f
Show file tree

Hide file tree

Showing 11 changed files with 17 additions and 17 deletions.
diff --git a/src/final-JATS-schematron.sch b/src/final-JATS-schematron.sch
@@ -4184,7 +4184,7 @@
       <assert test="anonymous" role="error" id="prc-reviewer-test-2">[prc-reviewer-test-2] A reviewer contrib in a PRC article must have a child anonymous element. This one does not - <value-of select="."/>.</assert>
     </rule></pattern><pattern id="prc-pub-review-tests-pattern"><rule context="article[e:is-prc(.)]" id="prc-pub-review-tests">
 
-      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="error" id="prc-pub-review-test-1">[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</report>
+      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="warning" id="prc-pub-review-test-1">[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</report>
     </rule></pattern>
 
   <pattern id="sub-article-doi-checks-pattern"><rule context="sub-article/front-stub/article-id[@pub-id-type='doi']" id="sub-article-doi-checks">

diff --git a/src/final-JATS-schematron.xsl b/src/final-JATS-schematron.xsl
@@ -24565,15 +24565,15 @@
    <xsl:template match="article[e:is-prc(.)]" priority="1000" mode="M379">
       <svrl:fired-rule xmlns:svrl="http://purl.oclc.org/dsdl/svrl" context="article[e:is-prc(.)]" id="prc-pub-review-tests"/>
 
-		    <!--REPORT error-->
+		    <!--REPORT warning-->
       <xsl:if test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )">
          <svrl:successful-report xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and ( sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')] or sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')] )">
             <xsl:attribute name="id">prc-pub-review-test-1</xsl:attribute>
-            <xsl:attribute name="role">error</xsl:attribute>
+            <xsl:attribute name="role">warning</xsl:attribute>
             <xsl:attribute name="location">
                <xsl:apply-templates select="." mode="schematron-select-full-path"/>
             </xsl:attribute>
-            <svrl:text>[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</svrl:text>
+            <svrl:text>[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</svrl:text>
          </svrl:successful-report>
       </xsl:if>
       <xsl:apply-templates select="*" mode="M379"/>

diff --git a/src/final-package-JATS-schematron.sch b/src/final-package-JATS-schematron.sch
@@ -4190,7 +4190,7 @@
       <assert test="anonymous" role="error" id="prc-reviewer-test-2">A reviewer contrib in a PRC article must have a child anonymous element. This one does not - <value-of select="."/>.</assert>
     </rule></pattern><pattern id="prc-pub-review-tests-pattern"><rule context="article[e:is-prc(.)]" id="prc-pub-review-tests">
 
-      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="error" id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</report>
+      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="warning" id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</report>
     </rule></pattern>
 
   <pattern id="sub-article-doi-checks-pattern"><rule context="sub-article/front-stub/article-id[@pub-id-type='doi']" id="sub-article-doi-checks">

diff --git a/src/pre-JATS-schematron.sch b/src/pre-JATS-schematron.sch
@@ -4129,7 +4129,7 @@
       <assert test="anonymous" role="error" id="prc-reviewer-test-2">[prc-reviewer-test-2] A reviewer contrib in a PRC article must have a child anonymous element. This one does not - <value-of select="."/>.</assert>
     </rule></pattern><pattern id="prc-pub-review-tests-pattern"><rule context="article[e:is-prc(.)]" id="prc-pub-review-tests">
 
-      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="error" id="prc-pub-review-test-1">[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</report>
+      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="warning" id="prc-pub-review-test-1">[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</report>
     </rule></pattern>
 
   <pattern id="sub-article-doi-checks-pattern"><rule context="sub-article/front-stub/article-id[@pub-id-type='doi']" id="sub-article-doi-checks">

diff --git a/src/pre-JATS-schematron.xsl b/src/pre-JATS-schematron.xsl
@@ -24446,15 +24446,15 @@
    <xsl:template match="article[e:is-prc(.)]" priority="1000" mode="M377">
       <svrl:fired-rule xmlns:svrl="http://purl.oclc.org/dsdl/svrl" context="article[e:is-prc(.)]" id="prc-pub-review-tests"/>
 
-		    <!--REPORT error-->
+		    <!--REPORT warning-->
       <xsl:if test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )">
          <svrl:successful-report xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and ( sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')] or sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')] )">
             <xsl:attribute name="id">prc-pub-review-test-1</xsl:attribute>
-            <xsl:attribute name="role">error</xsl:attribute>
+            <xsl:attribute name="role">warning</xsl:attribute>
             <xsl:attribute name="location">
                <xsl:apply-templates select="." mode="schematron-select-full-path"/>
             </xsl:attribute>
-            <svrl:text>[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</svrl:text>
+            <svrl:text>[prc-pub-review-test-1] This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</svrl:text>
          </svrl:successful-report>
       </xsl:if>
       <xsl:apply-templates select="*" mode="M377"/>

diff --git a/src/schematron.sch b/src/schematron.sch
@@ -7549,8 +7549,8 @@ else self::*/local-name() = $allowed-p-blocks"
         or
         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]
         )"
-        role="error" 
-        id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</report>
+        role="warning" 
+        id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</report>
     </rule>
 
   </pattern>

diff --git a/test/tests/gen/prc-pub-review-tests/prc-pub-review-test-1/fail.xml b/test/tests/gen/prc-pub-review-tests/prc-pub-review-test-1/fail.xml
@@ -1,7 +1,7 @@
 <?oxygen SCHSchema="prc-pub-review-test-1.sch"?>
 <!--Context: article[e:is-prc(.)]
 Test: report    sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and ( sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')] or sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')] )
-Message: This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect. -->
+Message: This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct? -->
 <root xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
   <article>
     <front>

diff --git a/test/tests/gen/prc-pub-review-tests/prc-pub-review-test-1/pass.xml b/test/tests/gen/prc-pub-review-tests/prc-pub-review-test-1/pass.xml
@@ -1,7 +1,7 @@
 <?oxygen SCHSchema="prc-pub-review-test-1.sch"?>
 <!--Context: article[e:is-prc(.)]
 Test: report    sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and ( sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')] or sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')] )
-Message: This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect. -->
+Message: This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct? -->
 <root xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
   <article>
     <front>

diff --git a/test/tests/gen/prc-pub-review-tests/prc-pub-review-test-1/prc-pub-review-test-1.sch b/test/tests/gen/prc-pub-review-tests/prc-pub-review-test-1/prc-pub-review-test-1.sch
@@ -1287,7 +1287,7 @@
   </xsl:function>
   <pattern id="sub-article-version-2">
     <rule context="article[e:is-prc(.)]" id="prc-pub-review-tests">
-      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="error" id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</report>
+      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="warning" id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</report>
     </rule>
   </pattern>
   <pattern id="root-pattern">

diff --git a/test/xspec/schematron.sch b/test/xspec/schematron.sch
@@ -5376,7 +5376,7 @@
   <pattern id="prc-pub-review-tests-pattern">
     <rule context="article[e:is-prc(.)]" id="prc-pub-review-tests">
 
-      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="error" id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review. This must be incorrect.</report>
+      <report test="sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'reviewer #')] and (         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'consensus')]          or         sub-article[@article-type='referee-report']/front-stub//article-title[starts-with(lower-case(.),'joint')]         )" role="warning" id="prc-pub-review-test-1">This article has individual public reviews, and also either a consensus or a joint public review, which is highgly unusual. Is this correct?</report>
     </rule>
   </pattern>
 

diff --git a/test/xspec/schematron.xspec b/test/xspec/schematron.xspec
@@ -9979,12 +9979,12 @@
     <x:scenario label="prc-pub-review-tests">
       <x:scenario label="prc-pub-review-test-1-pass">
         <x:context href="../tests/gen/prc-pub-review-tests/prc-pub-review-test-1/pass.xml"/>
-        <x:expect-not-report id="prc-pub-review-test-1" role="error"/>
+        <x:expect-not-report id="prc-pub-review-test-1" role="warning"/>
         <x:expect-not-assert id="prc-pub-review-tests-xspec-assert" role="error"/>
       </x:scenario>
       <x:scenario label="prc-pub-review-test-1-fail">
         <x:context href="../tests/gen/prc-pub-review-tests/prc-pub-review-test-1/fail.xml"/>
-        <x:expect-report id="prc-pub-review-test-1" role="error"/>
+        <x:expect-report id="prc-pub-review-test-1" role="warning"/>
         <x:expect-not-assert id="prc-pub-review-tests-xspec-assert" role="error"/>
       </x:scenario>
     </x:scenario>