Skip to content

Commit

Permalink
Merge pull request #598 from elifesciences/pr-597
Browse files Browse the repository at this point in the history
Remove collection pub check
  • Loading branch information
fred-atherden authored Feb 29, 2024
2 parents 0b94a3f + c2b1d63 commit 0725167
Show file tree
Hide file tree
Showing 11 changed files with 5 additions and 1,658 deletions.
4 changes: 1 addition & 3 deletions src/final-JATS-schematron.sch
Original file line number Diff line number Diff line change
Expand Up @@ -1433,9 +1433,7 @@

<assert test="title-group[article-title]" role="error" id="test-title-group-presence">[test-title-group-presence] title-group containing article-title must be present.</assert>

<assert test="pub-date[@publication-format='electronic'][@date-type='publication']" role="error" id="test-epub-date">[test-epub-date] There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<report test="not($is-prc) and not(pub-date[@pub-type='collection'])" role="error" id="test-pub-collection-presence">[test-pub-collection-presence] There must be a child pub-date[@pub-type='collection'] in article-meta.</report>
<assert test="pub-date[@publication-format='electronic'][@date-type='publication']" role="error" id="test-epub-date">[test-epub-date] There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<assert test="volume" role="error" id="test-volume-presence">[test-volume-presence] There must be a child volume in article-meta.</assert>

Expand Down
12 changes: 0 additions & 12 deletions src/final-JATS-schematron.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -6605,18 +6605,6 @@
</xsl:otherwise>
</xsl:choose>

<!--REPORT error-->
<xsl:if test="not($is-prc) and not(pub-date[@pub-type='collection'])">
<svrl:successful-report xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="not($is-prc) and not(pub-date[@pub-type='collection'])">
<xsl:attribute name="id">test-pub-collection-presence</xsl:attribute>
<xsl:attribute name="role">error</xsl:attribute>
<xsl:attribute name="location">
<xsl:apply-templates select="." mode="schematron-select-full-path"/>
</xsl:attribute>
<svrl:text>[test-pub-collection-presence] There must be a child pub-date[@pub-type='collection'] in article-meta.</svrl:text>
</svrl:successful-report>
</xsl:if>

<!--ASSERT error-->
<xsl:choose>
<xsl:when test="volume"/>
Expand Down
4 changes: 1 addition & 3 deletions src/final-package-JATS-schematron.sch
Original file line number Diff line number Diff line change
Expand Up @@ -1439,9 +1439,7 @@

<assert test="title-group[article-title]" role="error" id="test-title-group-presence">title-group containing article-title must be present.</assert>

<assert test="pub-date[@publication-format='electronic'][@date-type='publication']" role="error" id="test-epub-date">There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<report test="not($is-prc) and not(pub-date[@pub-type='collection'])" role="error" id="test-pub-collection-presence">There must be a child pub-date[@pub-type='collection'] in article-meta.</report>
<assert test="pub-date[@publication-format='electronic'][@date-type='publication']" role="error" id="test-epub-date">There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<assert test="volume" role="error" id="test-volume-presence">There must be a child volume in article-meta.</assert>

Expand Down
4 changes: 1 addition & 3 deletions src/pre-JATS-schematron.sch
Original file line number Diff line number Diff line change
Expand Up @@ -1378,9 +1378,7 @@

<assert test="title-group[article-title]" role="error" id="test-title-group-presence">[test-title-group-presence] title-group containing article-title must be present.</assert>

<assert test="pub-date[@publication-format='electronic'][@date-type='publication']" role="error" id="test-epub-date">[test-epub-date] There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<report test="not($is-prc) and not(pub-date[@pub-type='collection'])" role="error" id="test-pub-collection-presence">[test-pub-collection-presence] There must be a child pub-date[@pub-type='collection'] in article-meta.</report>
<assert test="pub-date[@publication-format='electronic'][@date-type='publication']" role="error" id="test-epub-date">[test-epub-date] There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<assert test="volume" role="error" id="test-volume-presence">[test-volume-presence] There must be a child volume in article-meta.</assert>

Expand Down
12 changes: 0 additions & 12 deletions src/pre-JATS-schematron.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -6525,18 +6525,6 @@
</xsl:otherwise>
</xsl:choose>

<!--REPORT error-->
<xsl:if test="not($is-prc) and not(pub-date[@pub-type='collection'])">
<svrl:successful-report xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="not($is-prc) and not(pub-date[@pub-type='collection'])">
<xsl:attribute name="id">test-pub-collection-presence</xsl:attribute>
<xsl:attribute name="role">error</xsl:attribute>
<xsl:attribute name="location">
<xsl:apply-templates select="." mode="schematron-select-full-path"/>
</xsl:attribute>
<svrl:text>[test-pub-collection-presence] There must be a child pub-date[@pub-type='collection'] in article-meta.</svrl:text>
</svrl:successful-report>
</xsl:if>

<!--ASSERT error-->
<xsl:choose>
<xsl:when test="volume"/>
Expand Down
6 changes: 1 addition & 5 deletions src/schematron.sch
Original file line number Diff line number Diff line change
Expand Up @@ -1585,11 +1585,7 @@

<assert test="pub-date[@publication-format='electronic'][@date-type='publication']"
role="error"
id="test-epub-date">There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<report test="not($is-prc) and not(pub-date[@pub-type='collection'])"
role="error"
id="test-pub-collection-presence">There must be a child pub-date[@pub-type='collection'] in article-meta.</report>
id="test-epub-date">There must be a child pub-date[@publication-format='electronic'][@date-type='publication'] in article-meta.</assert>

<assert test="volume"
role="error"
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit 0725167

Please sign in to comment.