Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWindow: Put search toolbar in a title stack #668

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

danirabbit
Copy link
Member

Instead of adding a whole new toolbar, re-use this title area that has nothing else in it

Screenshot from 2022-07-06 14 13 56

@danirabbit danirabbit requested a review from a team July 6, 2022 21:16
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a noticeable visual glitch on startup caused by the title label being revealed. Apart from that this works as expected and the code looks good.

jeremypw
jeremypw previously approved these changes Jul 7, 2022
# Conflicts fixed in:
#	src/MainWindow.vala
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this wasn't merged before. Code good and no glitch now.

@jeremypw jeremypw merged commit c9a60a3 into master Oct 21, 2023
5 checks passed
@jeremypw jeremypw deleted the mainwindow-findstack branch October 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants