Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple search in playlist #765

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Implement simple search in playlist #765

merged 11 commits into from
Aug 6, 2024

Conversation

jeremypw
Copy link
Collaborator

Fixes #762

  • Just adds a search entry to the queue header that appears whenever there are items in the queue.
  • Entering a search term does a case insensitive search for the term anywhere in the titles in list and selects the first matching row (if any).
  • If no match the currently selected item remains selected.
  • The matching row does not play until the search entry is activated or the row is clicked on.
  • The queue scrolls to show the matched item.
  • <Ctrl>F focuses the search entry if showing

Screenshot from 2023-12-14 16 49 39

@jeremypw jeremypw requested a review from a team December 14, 2023 16:50
@zeebok
Copy link
Contributor

zeebok commented May 23, 2024

This never seems to allow the first item in the list as a result to highlight, which is handy if I search in a list that is long and scrollable

@jeremypw
Copy link
Collaborator Author

jeremypw commented Aug 5, 2024

@zeebok Sorry for the delay in getting back to this. I have now fixed the issue you noticed.

@jeremypw jeremypw merged commit f8b0df0 into main Aug 6, 2024
3 checks passed
@jeremypw jeremypw deleted the search-in-playlist branch August 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search mechanism in the app
3 participants